mureinik commented on code in PR #4484:
URL: https://github.com/apache/eventmesh/pull/4484#discussion_r1358437938
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/util/BannerUtilTest.java:
##########
@@ -17,17 +17,13 @@
package org.apache.eventmesh.runtime.util;
-import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
public class BannerUtilTest {
@Test
public void testGenerateBanner() {
- try {
- BannerUtil.generateBanner();
- } catch (Exception e) {
- Assertions.fail("BannerUtil.generateBanner() test failed");
- }
+ // Must not throw an exception
+ BannerUtil.generateBanner();
Review Comment:
fixed
##########
eventmesh-runtime/src/test/java/org/apache/eventmesh/runtime/util/EventMeshUtilTest.java:
##########
@@ -167,13 +167,10 @@ public void testCloneObject() throws IOException,
ClassNotFoundException {
@Test
public void testPrintState() {
- try {
- ScheduledExecutorService serviceRebalanceScheduler =
ThreadPoolFactory
- .createScheduledExecutor(5, new
EventMeshThreadFactory("proxy-rebalance-sch", true));
- EventMeshUtil.printState((ThreadPoolExecutor)
serviceRebalanceScheduler);
- } catch (Exception e) {
- Assertions.fail(e.getMessage());
- }
+ // Must not throw an exception
+ ScheduledExecutorService serviceRebalanceScheduler = ThreadPoolFactory
+ .createScheduledExecutor(5, new
EventMeshThreadFactory("proxy-rebalance-sch", true));
+ EventMeshUtil.printState((ThreadPoolExecutor)
serviceRebalanceScheduler);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
