pandaapo commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1387855843
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
This is my question. I saw multiple instances of such code where the passed
in timeout was not used. So is this indicating that your previous refactoring
of retry in memory using `HashedWheelTimer` was incomplete before, or is it due
to inheritance system design?
这是我的一个疑问。看到多处这样的代码，没有使用传入的Timeout。所以这是表示你之前用`HashedWheelTimer`对内存中重试的重构不完全，还是继承体系设计的原因？
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
This is my question. I saw multiple instances of such code where the passed
in timeout was not used. So is this indicating that your previous refactoring
of retry in memory using `HashedWheelTimer` was incomplete before, or is it due
to inheritance system design?
这是我的一个疑问。看到多处这样的代码，没有使用传入的Timeout。所以这是表示你之前用`HashedWheelTimer`对内存中重试的重构不完全，还是继承体系设计的原因？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
