yanrongzhen commented on code in PR #4544:
URL: https://github.com/apache/eventmesh/pull/4544#discussion_r1387863893
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
This is for the RetryContext can be `rePut`, support the `Timeout` object
back into the time wheel, so I reserved the imported parameter.
---
这个是为了在RetryContext当中可以进行rePut操作, 支持把Timeout对象重新放到时间轮里, 所以我预留了该入参.
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/grpc/push/AbstractPushRequest.java:
##########
@@ -158,7 +158,7 @@ protected void removeWaitingMap(WebhookPushRequest request)
{
}
@Override
- public void run(Timeout timeout) throws Exception {
+ public void doRun(Timeout timeout) throws Exception {
tryPushRequest();
}
Review Comment:
This is for the RetryContext can be `rePut`, support the `Timeout` object
back into the time wheel, so I reserved the imported parameter.
---
这个是为了在RetryContext当中可以进行rePut操作, 支持把Timeout对象重新放到时间轮里, 所以我预留了该入参.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
