pandaapo commented on code in PR #4522:
URL: https://github.com/apache/eventmesh/pull/4522#discussion_r1391237538
##########
eventmesh-connectors/eventmesh-connector-feishu/src/main/java/org/apache/eventmesh/connector/feishu/config/FeishuServerConfig.java:
##########
@@ -25,8 +25,6 @@
@EqualsAndHashCode(callSuper = true)
public class FeishuServerConfig extends Config {
- private boolean sourceEnable;
-
private boolean sinkEnable;
Review Comment:
If you want to preserve this class and the `sinkEnable` attribute, keep the
server-config. yml file and the `sinkEnable` configuration item as well, and
add `if (serverConfig. isSinkEnable ()) {}` logic to the `FeishuConnectServer #
main()` method. Alternatively, delete this class.
如果要保留这个类和`sinkEnable`属性的话，就同样保留server-config.yml文件和`sinkEnable`配置项，并在`FeishuConnectServer#main()`方法中加上`if
(serverConfig.isSinkEnable()) {}`逻辑。或者将该类删除掉。
##########
eventmesh-connectors/eventmesh-connector-feishu/src/main/java/org/apache/eventmesh/connector/feishu/config/FeishuServerConfig.java:
##########
@@ -25,8 +25,6 @@
@EqualsAndHashCode(callSuper = true)
public class FeishuServerConfig extends Config {
- private boolean sourceEnable;
-
private boolean sinkEnable;
Review Comment:
If you want to preserve this class and the `sinkEnable` attribute, keep the
server-config. yml file and the `sinkEnable` configuration item as well, and
add `if (serverConfig. isSinkEnable ()) {}` logic to the `FeishuConnectServer #
main()` method. Alternatively, delete this class.
如果要保留这个类和`sinkEnable`属性的话，就同样保留server-config.yml文件和`sinkEnable`配置项，并在`FeishuConnectServer#main()`方法中加上`if
(serverConfig.isSinkEnable()) {}`逻辑。或者将该类删除掉。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
