pandaapo commented on code in PR #4522: URL: https://github.com/apache/eventmesh/pull/4522#discussion_r1412726681
########## eventmesh-connectors/eventmesh-connector-feishu/src/main/resources/sink-config.yml: ########## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +pubSubConfig: + meshAddress: 127.0.0.1:10000 + subject: TopicTest + idc: FT + env: PRD + group: feishuSink + appId: 5031 + userName: feishuSinkUser + passWord: feishuPassWord +connectorConfig: + connectorName: feishuSink + reciveId: reciveIdValue + reciveType: open_id Review Comment: Are you willing to fix this bug? @hhuang1231 . Additionally, this bug makes me worried about the correctness and effectiveness of this Connector in the absence of this bug. 您是否愿意修改这个bug？@hhuang1231 。另外，该bug也让我有点担心，当没有该bug时，该Connector的正确性和有效性。 ########## eventmesh-connectors/eventmesh-connector-feishu/src/main/resources/sink-config.yml: ########## @@ -0,0 +1,30 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +pubSubConfig: + meshAddress: 127.0.0.1:10000 + subject: TopicTest + idc: FT + env: PRD + group: feishuSink + appId: 5031 + userName: feishuSinkUser + passWord: feishuPassWord +connectorConfig: + connectorName: feishuSink + reciveId: reciveIdValue + reciveType: open_id Review Comment: Are you willing to fix this bug? @hhuang1231 . Additionally, this bug makes me worried about the correctness and effectiveness of this Connector in the absence of this bug. 您是否愿意修改这个bug？@hhuang1231 。另外，该bug也让我有点担心，当没有该bug时，该Connector的正确性和有效性。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
