pandaapo commented on issue #4416: URL: https://github.com/apache/eventmesh/issues/4416#issuecomment-1818379449
> Thanks for your reply. I think that Webhooks are the most efficient way to retrieve data since they don't need any polling. > > But one thing still confuses me. Webhooks require a [Payload URL](https://docs.github.com/en/webhooks/using-webhooks/creating-webhooks#creating-a-repository-webhook) and will make POST requests after certain events have occurred. Is it proper to make the source connector an HTTP server to provide this URL? If we use this approach, perhaps we can implement an HTTP source connector and reuse it in the GitHub source connector. HTTP source is waiting for implementation. If you are interested, you can implement it first. https://github.com/apache/eventmesh/tree/master/eventmesh-connectors#connector-status If you want to implement GitHub source first, you can first enable it to support REST API, or GraphQL API, or both. Then, after HTTP source is implemented by community, if it is suitable for GitHub source reuse, you can add Webhooks to GitHub source. If you only want to implement GitHub source that supports Webhooks first, you can create a lightweight HTTP Server in GitHub source. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
