pandaapo commented on issue #4416: URL: https://github.com/apache/eventmesh/issues/4416#issuecomment-1822403969
> The HTTP source will be implemented with the native [HttpServer](https://docs.oracle.com/javase/8/docs/jre/api/net/httpserver/spec/com/sun/net/httpserver/HttpServer.html). > > In `source-config.yml`,we can configure the `path `and `port`. For example, the following configuration creates an API `POST http://127.0.0.1:3000/test`. We can call it in various ways (e.g. curl, GitHub Webhooks, etc.) to send messages. > > ```yaml > connectorConfig: > connectorName: httpSource > path: /test > port: 3000 > ``` > > The HTTP Source Connector converts the request body into a CloudEvent. For convenience, the request body should be provided in `json` format. If you are willing, you can use Jetty, Tomcat, or Netty, which are more stable and efficient implementations of HTTP Server. Of course, if you insist on using the one provided by JDK, you can also do that. So, this design looks fine to me. What do you think of this design of HTTP Source Connector? @xwm1992 Additionally, @Fungx plans to reuse this connector in the GitHub Source Connector implemented in Webhook way. I think that's also fine. What do you think? @xwm1992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
