pandaapo commented on code in PR #4634: URL: https://github.com/apache/eventmesh/pull/4634#discussion_r1421742628
########## tools/dependency-check/known-dependencies.txt: ########## @@ -25,6 +25,7 @@ cache-api-1.1.1.jar checker-qual-3.12.0.jar cloudevents-api-2.4.2.jar cloudevents-core-2.4.2.jar +cloudevents-http-vertx-2.3.0.jar Review Comment: > Actually, I'm confused about `known-dependencies.txt`. Why do we need to manually add dependencies here? Since we are already using a build tool. I don't fully understand either, I only know that the script check-dependencies.sh for checking dependencies will use this file to check. I also want to know the purpose of using this method of checking @ruanwenjun , and whether there is a better way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
