pandaapo commented on PR #4634: URL: https://github.com/apache/eventmesh/pull/4634#issuecomment-1849705152
> Maybe this question shouldn't be asked here, but I still want to know why most sourceConnectors don't implement the `commit()` method. @hhuang1231 `commit()` is mainly used to record the offset of messages that need to be persisted, and to avoid duplicate transmission of such messages as much as possible. However, not all connectors need to implement it, such as this Connector and the Lark Connector you refactored. Connectors such as RocketMQ, RabbitMQ, Kafka, MySQL, etc. should implement to make them more reliable. Of course, there are currently some connectors that need to implement it but have not implemented. The community wants to gradually improve the functionality of a Connector and does not require contributors to implement all functions in one PR. `commit()`是主要用于记录需要持久化的消息的位移，尽量避免这类消息的重复传输，但不是所有的Connector都需要实现，像该Connector、您重构的Lark Connector等不需要实现。像RocketMQ、RabbitMQ、Kafka、MySQL等这类的Connector，应该实现，这样Connector会更加可靠。当然，目前有一些需要实现的Connector并没有实现，社区是想逐步完善一个Connector的功能，不强制要求贡献这在一次PR中全部实现。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
