pandaapo commented on code in PR #4644:
URL: https://github.com/apache/eventmesh/pull/4644#discussion_r1426011097
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java:
##########
@@ -85,7 +85,8 @@ public EventMeshGrpcConsumer(final EventMeshGrpcClientConfig
clientConfig) {
}
public void init() {
- this.channel =
ManagedChannelBuilder.forAddress(clientConfig.getServerAddr(),
clientConfig.getServerPort()).usePlaintext().build();
+ this.channel =
ManagedChannelBuilder.forAddress(clientConfig.getServerAddr(),
clientConfig.getServerPort()).enableRetry().usePlaintext()
Review Comment:
Doesn't gRPC generally supports retry by default? Or rather, it's not like
that, we must manually enable retry?
gRPC一般不是默认支持重试吗？还是说并非如此，必须手动开启重试？
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/EventMeshGrpcConsumer.java:
##########
@@ -85,7 +85,8 @@ public EventMeshGrpcConsumer(final EventMeshGrpcClientConfig
clientConfig) {
}
public void init() {
- this.channel =
ManagedChannelBuilder.forAddress(clientConfig.getServerAddr(),
clientConfig.getServerPort()).usePlaintext().build();
+ this.channel =
ManagedChannelBuilder.forAddress(clientConfig.getServerAddr(),
clientConfig.getServerPort()).enableRetry().usePlaintext()
Review Comment:
Doesn't gRPC generally supports retry by default? Or rather, it's not like
that, we must manually enable retry?
gRPC一般不是默认支持重试吗？还是说并非如此，必须手动开启重试？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
