Pil0tXia commented on code in PR #4644:
URL: https://github.com/apache/eventmesh/pull/4644#discussion_r1426231043
##########
eventmesh-sdks/eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/SubStreamHandler.java:
##########
@@ -99,8 +99,7 @@ public void onNext(final CloudEvent message) {
@Override
public void onError(final Throwable t) {
- LogUtils.error(log, "Received Server side error", t);
- close();
+ log.error("Received Server side error", t);
Review Comment:
gRPC keepAlive connections have the ability to automatically close the
connection when C/S times out, without the need to manually call close().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
