Pil0tXia commented on code in PR #4650:
URL: https://github.com/apache/eventmesh/pull/4650#discussion_r1440245239
##########
eventmesh-connectors/eventmesh-connector-file/src/main/java/org/apache/eventmesh/connector/file/source/connector/FileSourceConnector.java:
##########
@@ -73,12 +93,48 @@ public String name() {
@Override
public void stop() {
-
+ try {
+ if (bufferedReader != null) {
+ bufferedReader.close();
+ }
+ } catch (Exception e) {
+ log.error("Error closing resources: {}", e.getMessage());
+ }
}
@Override
public List<ConnectRecord> poll() {
- return null;
+ List<ConnectRecord> connectRecords = new ArrayList<>();
+ try {
+ String line;
+ while ((line = bufferedReader.readLine()) != null) {
+ ConnectRecord connectRecord = new ConnectRecord(new
RecordPartition(), new RecordOffset(), System.currentTimeMillis(), line);
Review Comment:
Reading the entire file may potentially impose significant memory pressure.
It is necessary to set a memory limit or read the file in segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
