xwm1992 commented on code in PR #4650:
URL: https://github.com/apache/eventmesh/pull/4650#discussion_r1449677981
##########
eventmesh-connectors/eventmesh-connector-file/src/main/java/org/apache/eventmesh/connector/file/source/connector/FileSourceConnector.java:
##########
@@ -73,12 +93,65 @@ public String name() {
@Override
public void stop() {
-
+ try {
+ if (bufferedReader != null) {
+ bufferedReader.close();
+ }
+ } catch (Exception e) {
+ log.error("Error closing resources: {}", e.getMessage());
+ }
}
@Override
public List<ConnectRecord> poll() {
- return null;
+ List<ConnectRecord> connectRecords = new
ArrayList<>(DEFAULT_BATCH_SIZE);
+ try {
+ int bytesRead;
+ long lastOffset = 0;
+ long prevTimeStamp = 0;
+ char[] buffer = new char[1024];
+ while ((bytesRead = bufferedReader.read(buffer)) != -1) {
+ String line = new String(buffer, 0, bytesRead);
+ lastOffset += bytesRead;
+ long timeStamp = System.currentTimeMillis();
+ RecordOffset recordOffset = convertToRecordOffset(lastOffset);
+ RecordPartition recordPartition =
convertToRecordPartition(this.sourceConfig.getConnectorConfig().getTopic(),
fileName);
+ ConnectRecord connectRecord = new
ConnectRecord(recordPartition, recordOffset, timeStamp, line);
+ connectRecords.add(connectRecord);
+ if (timeStamp - prevTimeStamp >
this.sourceConfig.getConnectorConfig().getCommitOffsetIntervalMs()) {
+ this.commitOffset(connectRecord, lastOffset);
Review Comment:
@HarshSawarkar There is no need to consider implementing the concept of
offset in the file source connector. For the ability to resume uploading from a
breakpoint, you only need to retransmit the entire file content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
