Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1442474333
##########
eventmesh-connectors/eventmesh-connector-spring/build.gradle:
##########
@@ -15,22 +15,16 @@
* limitations under the License.
*/
-configurations {
- implementation.exclude group: 'ch.qos.logback', module: 'logback-classic'
- implementation.exclude group: 'log4j', module: 'log4j'
- testImplementation.exclude group: 'org.apache.logging.log4j', module:
'log4j-to-slf4j'
-}
-
dependencies {
api project(":eventmesh-openconnect:eventmesh-openconnect-java")
implementation project(":eventmesh-common")
implementation project(":eventmesh-sdks:eventmesh-sdk-java")
- implementation
"org.springframework.boot:spring-boot-starter:$spring_boot_version"
- implementation
"org.springframework.boot:spring-boot-starter-validation:$spring_boot_version"
- implementation "org.springframework:spring-messaging:$spring_version"
+ implementation "org.springframework.boot:spring-boot-starter-validation"
+ implementation "org.springframework:spring-messaging"
+
Review Comment:
Why don't we exclude `spring-boot-starter-logging` instead of removing
`spring-boot-starter` here?
@yanrongzhen Please have a check
##########
build.gradle:
##########
@@ -160,56 +250,60 @@ task zip(type: Zip) {
}
}
-task installPlugin() {
- if (!new File("${rootDir}/dist").exists()) {
- return
- }
- String[] libJars = java.util.Optional.ofNullable(new
File("${rootDir}/dist/lib").list()).orElseGet(() -> new String[0])
- getAllprojects().forEach(subProject -> {
- var file = new File("${subProject.projectDir}/gradle.properties")
- if (!file.exists()) {
+tasks.register('installPlugin') {
+ doLast {
+ if (!new File("${rootDir}/dist").exists()) {
return
}
Review Comment:
I don't quite grasp the alterations made on `dist` and `installPlugin`
tasks. There have been several changes in grammar, such as why "doLast" was
added in this case?
##########
tools/dependency-check/check-dependencies.sh:
##########
@@ -34,14 +34,14 @@ self_modules_txt='tools/dependency-check/self-modules.txt'
# store all third part dependencies
third_party_dependencies_txt='tools/dependency-check/third-party-dependencies.txt'
-mkdir $decompress_conf || true
+mkdir -p $decompress_conf
tar -zxf build/eventmesh*.tar.gz -C $decompress_conf
./gradlew printProjects | grep '.jar' > "$self_modules_txt"
-find "$decompress_conf" -name "*.jar" -exec basename {} \; | uniq | sort >
"$all_dependencies_txt"
+find "$decompress_conf" -name "*.jar" -exec basename {} \; | sort | uniq >
"$all_dependencies_txt"
-grep -wvf "$self_modules_txt" "$all_dependencies_txt" | uniq | sort >
"$third_party_dependencies_txt"
+grep -wvf "$self_modules_txt" "$all_dependencies_txt" | sort | uniq >
"$third_party_dependencies_txt"
# If the check is success it will return 0
Review Comment:
It seems switching `sort` and `uniq` won't change the result, but speed up a
little, right?
##########
tools/dependency-check/known-dependencies.txt:
##########
Review Comment:
@xwm1992 Do we have to maintain this lengthy text?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
