ppkarwasz commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1442582453
##########
eventmesh-connectors/eventmesh-connector-spring/build.gradle:
##########
@@ -15,22 +15,16 @@
* limitations under the License.
*/
-configurations {
- implementation.exclude group: 'ch.qos.logback', module: 'logback-classic'
- implementation.exclude group: 'log4j', module: 'log4j'
- testImplementation.exclude group: 'org.apache.logging.log4j', module:
'log4j-to-slf4j'
-}
-
dependencies {
api project(":eventmesh-openconnect:eventmesh-openconnect-java")
implementation project(":eventmesh-common")
implementation project(":eventmesh-sdks:eventmesh-sdk-java")
- implementation
"org.springframework.boot:spring-boot-starter:$spring_boot_version"
- implementation
"org.springframework.boot:spring-boot-starter-validation:$spring_boot_version"
- implementation "org.springframework:spring-messaging:$spring_version"
+ implementation "org.springframework.boot:spring-boot-starter-validation"
+ implementation "org.springframework:spring-messaging"
+
Review Comment:
The removal of `spring-boot-starter` was not intentional, I'll add it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
