HarshSawarkar commented on code in PR #4650:
URL: https://github.com/apache/eventmesh/pull/4650#discussion_r1451491405
##########
eventmesh-connectors/eventmesh-connector-file/src/main/resources/source-config.yml:
##########
@@ -26,15 +25,7 @@ pubSubConfig:
passWord: filePassWord
connectorConfig:
connectorName: fileSource
- nameserver: 127.0.0.1:9877
topic: TopicTest
Review Comment:
@pandaapo Sure, I will update the PR. Just for my knowledge, I wanted to
know the usage of **_topic_** in the source connector. Also, in the
**_ConnectorConfig_**, the _**topic**_ was used only once, as in every other
**_source-config.yml_** file for other source connectors. So, would removing
topic be a good idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
