scwlkq commented on code in PR #55:
URL:
https://github.com/apache/eventmesh-dashboard/pull/55#discussion_r1518731629
##########
eventmesh-dashboard-core/src/main/java/org/apache/eventmesh/dashboard/core/store/RocketmqTopicCore.java:
##########
@@ -17,42 +17,57 @@
package org.apache.eventmesh.dashboard.core.store;
+
import org.apache.eventmesh.dashboard.common.model.TopicProperties;
-import org.apache.eventmesh.dashboard.core.config.AdminProperties;
+import org.apache.eventmesh.dashboard.common.properties.RocketmqProperties;
+import org.apache.eventmesh.dashboard.common.util.RocketmqUtils;
import org.apache.eventmesh.dashboard.service.store.TopicCore;
+import org.apache.rocketmq.common.TopicConfig;
+import org.apache.rocketmq.common.TopicFilterType;
+import org.apache.rocketmq.common.constant.PermName;
+
+import java.util.ArrayList;
import java.util.List;
import org.springframework.stereotype.Service;
import lombok.extern.slf4j.Slf4j;
-/**
- * TODO implement methods from storage-plugin.admin
- */
-
@Slf4j
@Service
public class RocketmqTopicCore implements TopicCore {
- AdminProperties adminProperties;
+ private final RocketmqProperties rocketmqProperties;
- public RocketmqTopicCore(AdminProperties adminProperties) {
- this.adminProperties = adminProperties;
+ public RocketmqTopicCore(RocketmqProperties rocketmqProperties) {
+ this.rocketmqProperties = rocketmqProperties;
}
@Override
- public List<TopicProperties> getTopic() {
- return null;
+ public List<TopicProperties> getTopics() {
+ List<TopicConfig> topicConfigList =
+ RocketmqUtils.getTopics(rocketmqProperties.getNamesrvAddr(),
rocketmqProperties.getRequestTimeoutMillis());
+ List<TopicProperties> topicPropertiesList = new ArrayList<>();
+ for (TopicConfig topicConfig : topicConfigList) {
+ TopicProperties topicProperties = new TopicProperties();
+ topicProperties.setRocketmqTopicConfig(topicConfig);
+ topicPropertiesList.add(topicProperties);
+ }
+ return topicPropertiesList;
}
Review Comment:
我本来想的是RocketmqUtils的getTopics就直接返回SDK里原生的TopicConfig，然后TopicCore里再封装一层TopicProperties（这么写我是想兼容其他的中间件配置）。新的pr里我把转换这一步也放在rocketmqUtils里了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
