Pil0tXia commented on code in PR #55:
URL:
https://github.com/apache/eventmesh-dashboard/pull/55#discussion_r1523304698
##########
eventmesh-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java:
##########
@@ -28,6 +28,26 @@
@Data
public class TopicProperties {
- private TopicConfig rocketmqTopicConfig;
+ private static final String SEPARATOR = " ";
+
+ public static int defaultReadQueueNums = 16;
+
+ public static int defaultWriteQueueNums = 16;
+
+ private String topicName;
+
+ private int offset;
+
+ private int readQueueNums;
+
+ private int writeQueueNums;
+
+ private int perm;
+
+ private TopicFilterType topicFilterType;
+
+ private int topicSysFlag;
+
+ private boolean order;
Review Comment:
Is it necessary to add these fields in a dto?
##########
eventmesh-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java:
##########
@@ -28,6 +28,26 @@
@Data
public class TopicProperties {
- private TopicConfig rocketmqTopicConfig;
+ private static final String SEPARATOR = " ";
+
Review Comment:
What is the `SEPARATOR` used for?
##########
eventmesh-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/RocketmqProperties.java:
##########
@@ -15,7 +15,7 @@
* limitations under the License.
*/
-package org.apache.eventmesh.dashboard.service.properties;
+package org.apache.eventmesh.dashboard.common.model;
Review Comment:
"RocketmqProperties" and "TopicProperties" are two classes that end with
"Properties" and are placed in the "model" package. However, their meanings and
purposes are completely different. Additionally, "model" and "dto" are two
different concepts. I think you should consider renaming the class names and
package names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
