Pil0tXia commented on code in PR #55:
URL: 
https://github.com/apache/eventmesh-dashboard/pull/55#discussion_r1527193571


##########
eventmesh-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/model/TopicProperties.java:
##########
@@ -28,6 +28,26 @@
 @Data
 public class TopicProperties {
 
-    private TopicConfig rocketmqTopicConfig;
+    private static final String SEPARATOR = " ";
+

Review Comment:
   Why `SEPARATOR` should be placed in a dto?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to