scwlkq commented on code in PR #66: URL: https://github.com/apache/eventmesh-dashboard/pull/66#discussion_r1530186491
########## eventmesh-dashboard-console/pom.xml: ########## @@ -93,38 +86,9 @@ <!-- </exclusion>--> <!-- </exclusions>--> <!-- </dependency>--> - <!-- storage redis client --> - <dependency> - <groupId>io.lettuce</groupId> - <artifactId>lettuce-core</artifactId> - </dependency> - <!-- rocketmq client --> - <dependency> - <groupId>org.apache.rocketmq</groupId> - <artifactId>rocketmq-client</artifactId> - <version>4.9.4</version> - </dependency> - <dependency> - <groupId>org.apache.rocketmq</groupId> - <artifactId>rocketmq-tools</artifactId> - <version>5.2.0</version> - </dependency> - <!-- health check client end --> - <!-- Unit Test --> - <dependency> - <groupId>org.springframework.boot</groupId> - <artifactId>spring-boot-starter-test</artifactId> - <scope>test</scope> - </dependency> - <!-- TODO: remove junit4 dependency --> - <dependency> - <groupId>junit</groupId> - <artifactId>junit</artifactId> - <version>4.13.2</version> - <scope>test</scope> - </dependency> Review Comment: 1. 这个todo是从console里复制的 我想应该是饶同学的意思是从console中remove，说是“写给zzx同学看的，不影响的话可以直接删掉” 但是我试验了一下 console里一些test里是有junit的注解的 这样的话我就不删除了，稍后我会移掉todo，将`junit`移动回`console`里并且带上scope。 3. 我看饶同学移除掉了 我以为不需要了的 就没动这个依赖 我问询问饶同学，让先不要动 一堆东西相互依赖（不过EventMesh SDK确实可以移动一下） -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
