Pil0tXia commented on PR #66: URL: https://github.com/apache/eventmesh-dashboard/pull/66#issuecomment-2014485959
>rocketmqproperties属于中间件配置，如果是要从cosole读取然后发给core的话，两个模块都要用到，我就放在common了。topicProperties属于DTO No, RocketmqProperties is not part of the middleware configuration, it is used for passing parameters between console and core just like TopicProperties. If you need to refactor RocketmqConfig, you should create another new class. >the SDK artifact of rocketmq, redis and nacos放在common里，这下core和console不都能访问到了嘛 These SDKs should be placed in the core module after the console module's usage of these SDKs has been migrated to the core module. Could you please leave a TODO comment explaining the situation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
