Pil0tXia commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1560535446
##########
build.gradle:
##########
@@ -139,7 +139,59 @@ allprojects {
}
}
-task tar(type: Tar) {
+tasks.register('dist') {
+ subprojects.forEach { subProject ->
+ dependsOn("${subProject.path}:jar")
+ }
Review Comment:
>Here I accentuate that it depends on **all** tasks of type `jar`, e.g.
`:eventmesh-common:jar`.
Yeah I understand your code's meaning.
>Unless I am mistaken `dependsOn("jar")` means that the `:dist` task from
the root project will depend on the `:jar` task from the root project.
The original `dist` task did depend on the `:jar` task from the root project
and it works. I think it should be the same with your way.
Is it because the use of the `task.register` writting makes it impossible to
depend on the `jar` task from the root project anymore? I'd like to keep the
original way~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
