ppkarwasz commented on code in PR #4719:
URL: https://github.com/apache/eventmesh/pull/4719#discussion_r1560809181
##########
eventmesh-connectors/eventmesh-connector-rocketmq/build.gradle:
##########
@@ -16,25 +16,33 @@
*/
List rocketmq = [
+ "org.apache.rocketmq:rocketmq-acl:$rocketmq_version",
"org.apache.rocketmq:rocketmq-client:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-broker:$rocketmq_version",
"org.apache.rocketmq:rocketmq-common:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-store:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-namesrv:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-tools:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-remoting:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-logging:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
"org.apache.rocketmq:rocketmq-filter:$rocketmq_version",
- "org.apache.rocketmq:rocketmq-acl:$rocketmq_version",
+ "org.apache.rocketmq:rocketmq-logging:$rocketmq_version",
+ "org.apache.rocketmq:rocketmq-remoting:$rocketmq_version",
"org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version",
-
+ "org.apache.rocketmq:rocketmq-store:$rocketmq_version",
+ "org.apache.rocketmq:rocketmq-srvutil:$rocketmq_version"
]
dependencies {
api project(":eventmesh-openconnect:eventmesh-openconnect-java")
implementation project(":eventmesh-common")
implementation rocketmq
+ implementation("org.apache.rocketmq:rocketmq-broker:$rocketmq_version") {
+ // Remove logging backend implementations
+ exclude group: 'ch.qos.logback', module: 'logback-classic'
+ }
Review Comment:
I restored the list and put a comment with the link to the RocketMQ issue
that will allow you to remove the exclusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
