cnzakii commented on PR #4837: URL: https://github.com/apache/eventmesh/pull/4837#issuecomment-2060809947
@Pil0tXia I believe I've figured it out, I've found a specification for a standard webhook (https://www.standardwebhooks.com/ , https://github.com/standard-webhooks/standard-webhooks/blob/main/spec/standard-webhooks.md) . I'm not sure if it's really universal, but I think it will help me with my current job. It mentions payload, signature, failure retry, request timeout, etc. Are these all currently required by HttpSinkConnector ? If we only need failure retry and request timeout, you can indeed share a webClient with ordinary HTTP. We only need to set different timeouts and failure retry mechanisms for different situations, and add a queue to store data (I'm not sure if responses from plain HTTP need to be stored as well), if a more complete webhook is needed, such as different payloads, security signatures, etc., then we should indeed build a separate `WebhookSinkConnector`. > I thought that Webhook already has a lot of mature designs Are you referring to the implementation of open source webhook? Or something else related to webhook? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
