Pil0tXia commented on PR #4837: URL: https://github.com/apache/eventmesh/pull/4837#issuecomment-2060876276
@cnzakii Glad I could help. >It mentions payload, signature, failure retry, request timeout, etc. Are these all currently required by `HttpSinkConnector` ? - [x] payload: Of course. Normal HTTP request needs it too. - [ ] signature: If you are interested in it, you can refer to `org.apache.eventmesh.webhook.receive.protocol.GithubProtocol`, which is a client-side signature verification implement. The Webhook server (such as GitHub and the HTTP Sink Connector) would define a specification, and the client (such as HTTP Source Connector and the existing `eventmesh-webhook` module) has to fit it. I personally think that SSL is secure enough. - [x] failure retry: Great feature. Usually a HTTP service should have retry ability. - [x] request timeout: Of course. Normal HTTP request needs it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@eventmesh.apache.org For additional commands, e-mail: issues-h...@eventmesh.apache.org
