Github user rajuan commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/331#discussion_r112661421
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java
 ---
    @@ -225,6 +228,7 @@ private String buildSqlStringFromClientCriteria(final 
SearchParameters searchPar
     
             String extraCriteria = "";
    --- End diff --
    
    I feel supporting sqlSearch is futile..... based on the validation code, we 
can always find a workaround injection....
    I suggest getting rid of this support....


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to