Github user rajuan commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/331#discussion_r112660113
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java
---
@@ -225,6 +228,7 @@ private String buildSqlStringFromClientCriteria(final
SearchParameters searchPar
String extraCriteria = "";
if (sqlSearch != null) {
+ SQLInjectionValidator.validateSQLInput(sqlSearch);
--- End diff --
This check should done for all the string params that are received for eg.
in this class it should be checked for externalId, name and orderBy etc......
Also for completeness these checks needs to be done across all read
platform services
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
