[
https://issues.apache.org/jira/browse/FINERACT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16864007#comment-16864007
]
Michael Vorburger.ch commented on FINERACT-764:
-----------------------------------------------
[~muarachmann] on second thought, I now actually think that it would probably
be much better if we did not mix this up with MariaDB4j after all... because:
1. It will be and easier for people to understand and follow along if we don't
mix this with MariaDB4j - it's technically completely unrelated.
2. I also want to avoid any sort of new discussion re. LGPL and all re.
MariaDB4j, even if used only in test, having a transitive depdendency to that
JDBC driver, and the binaries.
3. This will avoid problems re. mysql versions and what not - it will be "just
like today", using an external local one - including on Travis CI.
What this means is that we'll need an {{AbstractSpringBootIntegrationTest}}
similar to {{AbstractSpringBootWithMariaDB4jIntegrationTest}} but which uses
the "normal" local mysql.
Are you planning to work on this? Do reach out with an Qs by commenting here,
or (better, more people will help) via [email protected]!
> Run Integration Tests using Spring Boot IT support instead of on Tomcat
> started separately by gradle-tomcat-plugin
> ------------------------------------------------------------------------------------------------------------------
>
> Key: FINERACT-764
> URL: https://issues.apache.org/jira/browse/FINERACT-764
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Michael Vorburger.ch
> Priority: Major
>
> https://github.com/apache/fineract/pull/525 for FINERACT-700 struggles to get
> "./gradlew integrationTest" working under an up-to-date Gradle version, due
> to the gradle-tomcat-plugin failing to start Tomcat. The problem can also be
> seen (on that PR, as it stands right now) via {{./gradlew tomcatrunwar}}.
> https://github.com/bmuschko/gradle-tomcat-plugin mentions that its author "I
> don't have much time to contribute anymore. In practice this means far less
> activity, responsiveness on issues and new releases from my end."
> What we IMHO really should do instead is to ditch our use of
> gradle-tomcat-plugin and just use Spring Boot's very nice built-in support
> for Integration Test, see here:
> *
> https://docs.spring.io/spring-boot/docs/2.1.5.RELEASE/reference/htmlsingle/#boot-features-testing-spring-applications
> * https://www.baeldung.com/spring-boot-testing (see 7. Integration Testing
> with @SpringBootTest)
> * https://reflectoring.io/spring-boot-test/
> I wouldn't have time for this, but perhaps someone would like to pick this up?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
