[ 
https://issues.apache.org/jira/browse/FINERACT-764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868984#comment-16868984
 ] 

Michael Vorburger.ch commented on FINERACT-764:
-----------------------------------------------

I've started doing above, see latest commited pushed to 
[https://github.com/apache/fineract/pull/525/commits,] and there is now a new 
{{SpringBootLoginTest}}, which uses a regular local DB instead of MariaDB4j. 
Unfortunately it does not yet pass - something with the (base?) URL seems to be 
off, and I'm struggling to figure out what it is.

Once {{SpringBootLoginTest}} passes, it should then (hopefully) be fairly quick 
to  make each of the real integration tests extends the (new) 
{{AbstractSpringBootIntegrationTest}} to run as Spring Boot integration test 
instead of against an external Tomcat started by the Gradle plugin.

> Run Integration Tests using Spring Boot IT support instead of on Tomcat 
> started separately by gradle-tomcat-plugin
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-764
>                 URL: https://issues.apache.org/jira/browse/FINERACT-764
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: Michael Vorburger.ch
>            Priority: Major
>
> https://github.com/apache/fineract/pull/525 for FINERACT-700 struggles to get 
> "./gradlew integrationTest" working under an up-to-date Gradle version, due 
> to the gradle-tomcat-plugin failing to start Tomcat. The problem can also be 
> seen (on that PR, as it stands right now) via {{./gradlew tomcatrunwar}}.
> https://github.com/bmuschko/gradle-tomcat-plugin mentions that its author "I 
> don't have much time to contribute anymore. In practice this means far less 
> activity, responsiveness on issues and new releases from my end."
> What we IMHO really should do instead is to ditch our use of 
> gradle-tomcat-plugin and just use Spring Boot's very nice built-in support 
> for Integration Test, see here:
> * 
> https://docs.spring.io/spring-boot/docs/2.1.5.RELEASE/reference/htmlsingle/#boot-features-testing-spring-applications
> * https://www.baeldung.com/spring-boot-testing (see 7. Integration Testing 
> with @SpringBootTest)
> * https://reflectoring.io/spring-boot-test/
> I wouldn't have time for this, but perhaps someone would like to pick this up?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to