[
https://issues.apache.org/jira/browse/FINERACT-780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884711#comment-16884711
]
Mohit Sinha edited comment on FINERACT-780 at 7/14/19 4:20 PM:
---------------------------------------------------------------
Looking at https://api.travis-ci.org/v3/job/518404770/log.txt
The only relevant logs I could find were
`01:16:34.706 [Retrofit-Idle] INFO o.a.f.i.h.processor.ProcessorHelper - URL :
http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn? Status : 200
org.apache.fineract.integrationtests.HookIntegrationTest >
shouldSendOfficeCreationNotification FAILED
java.lang.AssertionError at HookIntegrationTest.java:79
`
Maybe, it means that there wasn't a connection issue, but rather an issue
regarding the unique id. When somebody runs the tests simultaneously, that is
going to affect these tests.
Can you find out what exactly was the assertion error?
was (Author: mohitsinha):
Looking at https://api.travis-ci.org/v3/job/518404770/log.txt
The only relevant logs I could find were
```01:16:34.706 [Retrofit-Idle] INFO o.a.f.i.h.processor.ProcessorHelper - URL
: http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn? Status : 200
org.apache.fineract.integrationtests.HookIntegrationTest >
shouldSendOfficeCreationNotification FAILED
java.lang.AssertionError at HookIntegrationTest.java:79
```
Maybe, it means that there wasn't a connection issue, but rather an issue
regarding the unique id. When somebody runs the tests simultaneously, that is
going to affect these tests.
Can you find out what exactly was the assertion error?
> HookIntegrationTest is flaky
> ----------------------------
>
> Key: FINERACT-780
> URL: https://issues.apache.org/jira/browse/FINERACT-780
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger.ch
> Priority: Major
>
> Our org.apache.fineract.integrationtests.HookIntegrationTest seems to be
> "flaky" and occassionally arbitrary fails.
> This seems to have happened e.g. in
> https://github.com/apache/fineract/pull/557 as well as again in
> https://github.com/apache/fineract/pull/607.
> I suspect it's related to this in the code of that test:
> {code:java}
> // Subject to https://echo-webhook.herokuapp.com being up
> // See
> //
> http://www.jamesward.com/2014/06/11/testing-webhooks-was-a-pain-so-i-fixed-the-glitch
> final String payloadURL =
> "http://echo-webhook.herokuapp.com:80/Z7RXoCBdLSFMDrpn?";;
> this.hookHelper.createHook(payloadURL);
> {code}
> In an ideal world, even an integration test should not depend on an external
> service running on some arbitrary 3rd party website.
> What someone probably could do is to instead start some sort of Echo Server
> written in Java in-process as part of that test. Something like this may
> already exist as a library somewhere, or otherwise it probably wouldn't be
> terribly hard to write it.
> If this happens more often, perhaps just temporarily adding an {{@Igore}} for
> this test would be in order (until someone can do above).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
