[
https://issues.apache.org/jira/browse/FINERACT-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148191#comment-17148191
]
Michael Vorburger commented on FINERACT-1058:
---------------------------------------------
[~Manthan] I think we psoted above at about the same time (I hadn't seen the
comment when I wrote above), but again, if _OFFSET_ could be user supplied and
needs to be "validated" for safety to avoid SQL injections, then it could make
sense to have SQLBuilder support it, but otherwise it's better and simpler to
leave it out of it, and just use SQLBuilder to create the WHERE clause, and
then concatenate these other parts.
I'm also not sure if JDBC actually permits using things like ORDER BY, LIMIT
and OFFSET as JDBC prepared statement parameters, which is what SQLBuilder
ultimately is really for... it may be worth to first test if that actually
works? On both the Drizzle and the MySQL JDBC drivers..
> Add support for "limit" and "order by" query in SQLBuilder
> -----------------------------------------------------------
>
> Key: FINERACT-1058
> URL: https://issues.apache.org/jira/browse/FINERACT-1058
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Manthan Surkar
> Assignee: Manthan Surkar
> Priority: Major
>
> This is in continuation of the work done by [~vorburger] in
> https://github.com/apache/fineract/pull/725
> The SQL builder currently does not support limit and order by operation. We
> can either keep the operations independent of SQLbuilder (which is certainly
> not recommended imo) or add it as a part of it.
> WDYT [~vorburger] [~awasum]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
