[
https://issues.apache.org/jira/browse/FINERACT-1058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149363#comment-17149363
]
Manthan Surkar commented on FINERACT-1058:
------------------------------------------
In my opinion:
We can add the functionality to add orderBY,limit,offset.
Orderby -> check if it matches with column name regex
Limit -> should be an integer or "ALL"
Offset -> should be an integer
Note that all these 3 values come from the user, if we now add this
functionally we probably can remove the use validateSQLInjection function also?
And completely remove the validates input function.
WDTY? [~vorburger] [~awasum]
> Add support for "limit" and "order by" query in SQLBuilder
> -----------------------------------------------------------
>
> Key: FINERACT-1058
> URL: https://issues.apache.org/jira/browse/FINERACT-1058
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: Manthan Surkar
> Assignee: Manthan Surkar
> Priority: Major
> Fix For: 1.4.0
>
> Attachments: screenshot-1.png
>
>
> This is in continuation of the work done by [~vorburger] in
> https://github.com/apache/fineract/pull/725
> The SQL builder currently does not support limit and order by operation. We
> can either keep the operations independent of SQLbuilder (which is certainly
> not recommended imo) or add it as a part of it.
> WDYT [~vorburger] [~awasum]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
