[ 
https://issues.apache.org/jira/browse/FINERACT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160329#comment-17160329
 ] 

Petri Tuomola commented on FINERACT-1082:
-----------------------------------------

Thanks [~Manthan] - that's a good question!

I think the best place to get the version would probably be from the properties 
set by the Gradle Git property plugin 
([https://github.com/n0mer/gradle-git-properties])

Maybe most appropriate would be either the property git.closest.tag.name or 
maybe from the git.commit.id.describe? The former should have the last release 
tag name, the latter last release tag name + number of commits since the last 
release.

For this purpose, git.closest.tag.name may be more appropriate. And yes, I 
think the releaseVersion should point to the same property.

[~vorburger] - just noticed that for some reason these are not getting 
populated on [https://demo.fineract.dev/fineract-provider/actuator/info]. Maybe 
something to do about how you build the image? When I do docker-compose build 
on my local machine, the properties are correctly populated...

> Automate Fineract version number population into Swagger doc
> ------------------------------------------------------------
>
>                 Key: FINERACT-1082
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1082
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Petri Tuomola
>            Assignee: Manthan Surkar
>            Priority: Minor
>
> Currently the Fineract version (e.g. 1.4.0) for Swagger documentation is 
> hardcoded into fineract-provider/config/swagger/fineract-input.json. This 
> should be automatically populated based on current Fineract version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to