[ 
https://issues.apache.org/jira/browse/FINERACT-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160775#comment-17160775
 ] 

Petri Tuomola commented on FINERACT-1082:
-----------------------------------------

[~vorburger] For me, git.commit.id.describe on my local environment currently 
says "release-1.4.0-476-g9d6a2ee-dirty". That's because the last release tag on 
the repository is "release-1.4.0", there have been 476 commits since the 
release tag, and I have some uncommitted files in my working tree. 

So for a released build with no changes, this would say "1.3.0" or "1.4.0" - 
whatever the latest release tag is. The rest gets appended only if you have 
made changes since the release tag.

Btw it's strange that there's a "release-1.4.0" tag on apache/fineract. Firstly 
it doesn't match the format of the other release tags on the repository (i.e. 
"1.3.0") and secondly, 1.4.0 has not been released...

But with that oddity aside, wouldn't this be the right string to use as a 
version number for the API?

> Automate Fineract version number population into Swagger doc
> ------------------------------------------------------------
>
>                 Key: FINERACT-1082
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1082
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Petri Tuomola
>            Assignee: Manthan Surkar
>            Priority: Minor
>
> Currently the Fineract version (e.g. 1.4.0) for Swagger documentation is 
> hardcoded into fineract-provider/config/swagger/fineract-input.json. This 
> should be automatically populated based on current Fineract version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to