[
https://issues.apache.org/jira/browse/FINERACT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211263#comment-17211263
]
Aleksandar Vidakovic commented on FINERACT-1189:
------------------------------------------------
[~vorburger] I can try to get this into the current fineract-provider... I have
some doubts though that it will work, because the generated code will be
considered as belonging to fineract-provider... means: it will land in the same
jar file. I really think this should be done after the modular build is in
place... otherwise we'll have to redact the build more often than really needed.
Once the multi-module build is in place it's pretty much downhill. And as
mentioned before: FINERACT-1188 is a side effect from moving the build.gradle
file to the root folder.
As for adding the fineract-client code generator templates later, and adding
fineract-api and fineract-doc later: agreed.
> fineract-client as separate module
> ----------------------------------
>
> Key: FINERACT-1189
> URL: https://issues.apache.org/jira/browse/FINERACT-1189
> Project: Apache Fineract
> Issue Type: Sub-task
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
>
> Would it be possible to extract JUST the work related to making
> fineract-client as separate module from
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]?
> In terms of logical sequencing, perhaps this would be simplest to do after
> FINERACT-1188, with fineract-client as the 1st of more to come modules, but
> not yet including fineract-api and fineract-doc?
> I imagine that this would help with later making FINERACT-1102 possible?
> If it's possible, it's perhaps easier if you do not yet include any
> improvements to fineract-client - JUST the build changes, and then raise a
> separate PR after for changes such as adding
> src/main/templates/java/retrofit2/CollectionFormats.mustache and all those
> things? Create a separate JIRA, as a subtask here or standalone Improvement,
> about whatever all those changes are required for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
