[ 
https://issues.apache.org/jira/browse/FINERACT-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211961#comment-17211961
 ] 

Michael Vorburger commented on FINERACT-1189:
---------------------------------------------

I'm generally in favour of of eventually having fineract-client as separate 
module within the https://github.com/apache/fineract monorep, which I support.

The point about "releasing separately" would at least be partially mitigated if 
we (eventually) have FINERACT-1102 but WITH fully automated -SNAPSHOT releases.

One reason why checking in generated code is always a bad idea in the long run 
is that, invariable, someone will come along sooner or later and make "just 
some small" manual changes to the generated code. [~Grandolf49] I'm not saying 
you will, but it... will happen. Always does. I've been around this block a few 
times over the last 20 years! :P

> fineract-client as separate module
> ----------------------------------
>
>                 Key: FINERACT-1189
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1189
>             Project: Apache Fineract
>          Issue Type: Sub-task
>            Reporter: Michael Vorburger
>            Assignee: Aleksandar Vidakovic
>            Priority: Major
>
> Would it be possible to extract JUST the work related to making 
> fineract-client as separate module fromĀ 
> [https://github.com/apache/fineract/compare/develop...vidakovic:feature/FINERACT-1171]?
> In terms of logical sequencing, perhaps this would be simplest to do after 
> FINERACT-1188, with fineract-client as the 1st of more to come modules, but 
> not yet including fineract-api and fineract-doc?
> I imagine that this would help with later making FINERACT-1102 possible?
> If it's possible, it's perhaps easier if you do not yet include any 
> improvements to fineract-client - JUST the build changes, and then raise a 
> separate PR after for changes such as adding 
> src/main/templates/java/retrofit2/CollectionFormats.mustache and all those 
> things? Create a separate JIRA, as a subtask here or standalone Improvement, 
> about whatever all those changes are required for.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to