[
https://issues.apache.org/jira/browse/FINERACT-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211912#comment-17211912
]
Michael Vorburger commented on FINERACT-1154:
---------------------------------------------
For the future record, we had follow-up discussions about this on
[https://github.com/apache/fineract/pull/1387] and
[https://github.com/apache/fineract/pull/1390]. The TL;DR of the discussion
above is that the goal here is that currently this is wrong:
{noformat}$ git clone https://github.com/apache/fineract.git ; cd fineract
$ git describe
1.3.0-861-g3ee46b040
$ wget
https://search.maven.org/remotecontent?filepath=fr/brouillard/oss/jgitver/0.12.0/jgitver-0.12.0-executable.jar
-O ~/bin/jgitver-executable.jar
$ java -jar ~/bin/jgitver-executable.jar
1.3.1-744-develop{noformat}
But AFTER (either of) [~ptuomola] PR #1387 or my PR #1390 it will be correct:
{noformat}$ git describe
1.4.0-108-g09e08fdc7
$ java -jar ~/bin/jgitver-executable.jar
1.4.1-1-develop
{noformat}
BTW that _1.4.1-1-develop_ doesn't seem that great, to me personally - perhaps
we can customize that?
I've [made an
edit|https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=67640333&selectedPageVersions=66&selectedPageVersions=67]
to the Release Doc - please do improve, if not clear enough.
> Git branch strategy is wrong, use tags instead
> ----------------------------------------------
>
> Key: FINERACT-1154
> URL: https://issues.apache.org/jira/browse/FINERACT-1154
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Petri Tuomola
> Priority: Major
> Fix For: 1.5.0
>
>
> It seems wrong to me that we have 20 open branches (on
> https://github.com/apache/fineract/branches), including for the just released
> 1.4.0. IMHO a 1.4.0 should be a tag not a branch, and there could be a branch
> named 1.4.x instead - if anyone actually wanted to maintain that (which I
> doubt anyone does).
> [~aleks], [~ptuomola] or anyone else reading along here, do you agree?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
