[
https://issues.apache.org/jira/browse/FINERACT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216027#comment-17216027
]
Aleksandar Vidakovic commented on FINERACT-1208:
------------------------------------------------
[~vorburger] This won't be possible without adding at least one template to the
code generator. The fineract-client build will fail with the following
exception:
{code:java}
> Task :fineract-client:compileJava
/home/spaddo/workspace/fineract/vidakovic-fineract-develop/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/auth/OAuthOkHttpClient.java:71:
warning: [deprecation] create(MediaType,String) in RequestBody has been
deprecated
RequestBody body = request.getBody() != null ?
RequestBody.create(mediaType, request.getBody()) : null;
^
error: warnings found and -Werror specified
/home/spaddo/workspace/fineract/vidakovic-fineract-develop/fineract-client/build/generated/java/src/main/java/org/apache/fineract/client/ApiClient.java:273:
warning: [unchecked] unchecked cast
return (T) returned;
^
required: T
found: String
where T is a type-variable:
T extends Object declared in class GsonResponseBodyConverterToString
1 error
2 warnings> Task :fineract-client:compileJava FAILEDFAILURE: Build failed with
an exception.
{code}
How should we proceed here?
> -Werror javac compilerArg lost during move to multi modules
> -----------------------------------------------------------
>
> Key: FINERACT-1208
> URL: https://issues.apache.org/jira/browse/FINERACT-1208
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
> Fix For: 1.5.0
>
>
> While code reviewing https://github.com/apache/fineract/pull/1402/ for
> FINERACT-1189, I've just realized that as part of the overall FINERACT-1171
> effort to move to multi modules, and refactoring moves in the build scripts,
> we could be more careful not to introduce regressions.
> Specifically, I've noticed that the {{-Werror}} javac compilerArg introduced
> in FINERACT-959 was at least temporarily lost again (it's currently commented
> out with a TODO from the root {{/build.gradle}}, and being removed from
> {{fineract-provider/build.gradle}}.
> [~aleks] is this regression something you will fix and raise a PR for?
> [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
