[
https://issues.apache.org/jira/browse/FINERACT-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216029#comment-17216029
]
Michael Vorburger commented on FINERACT-1208:
---------------------------------------------
[~aleks] an alternative could be to have less strict code quality for generated
code. Whether is this {{-Werror}}, or Checkstyle, or SpotBugs - it's great for
{{fineract-provider}}, and in a perfect world should cover any hand-written
code in {{src/}} of {{fineract-client}} as well - but not
{{fineract-client/build/generated/java}}... quality checking that is not the
responsibility of the Fineract project (but of the project providing those
templates) - and there is nothing Fineract can (nor should, IMHO) do if there
are violations. It will just hinder expanding code quality metrics for our own
code. Do you see what I mean? Now how to actually do this right in this
build... is something you will know much better than me! ;)
> -Werror javac compilerArg lost during move to multi modules
> -----------------------------------------------------------
>
> Key: FINERACT-1208
> URL: https://issues.apache.org/jira/browse/FINERACT-1208
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: Aleksandar Vidakovic
> Priority: Major
> Fix For: 1.5.0
>
>
> While code reviewing https://github.com/apache/fineract/pull/1402/ for
> FINERACT-1189, I've just realized that as part of the overall FINERACT-1171
> effort to move to multi modules, and refactoring moves in the build scripts,
> we could be more careful not to introduce regressions.
> Specifically, I've noticed that the {{-Werror}} javac compilerArg introduced
> in FINERACT-959 was at least temporarily lost again (it's currently commented
> out with a TODO from the root {{/build.gradle}}, and being removed from
> {{fineract-provider/build.gradle}}.
> [~aleks] is this regression something you will fix and raise a PR for?
> [~ptuomola] FYI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
