[ 
https://issues.apache.org/jira/browse/FINERACT-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227674#comment-17227674
 ] 

Michael Vorburger commented on FINERACT-1256:
---------------------------------------------

I can actually easily reliably locally reproduce this test failure, and locally 
see that it's due to:
{noformat}
2020-11-07 01:45:35.906 ERROR 828113 --- [io-8443-exec-10] 
c.s.j.spi.container.ContainerResponse    : The RuntimeException could not be 
mapped to a response, re-throwing to the HTTP 
containerjava.lang.IllegalArgumentException: Invalid name: 
'Group_TestOffice--8541804519024130017': name must be letter, digit, period, or 
underscore
        at 
org.apache.poi.hssf.usermodel.HSSFName.validateName(HSSFName.java:204) 
~[poi-4.1.2.jar:4.1.2]
        at 
org.apache.poi.hssf.usermodel.HSSFName.setNameName(HSSFName.java:132) 
~[poi-4.1.2.jar:4.1.2]
        at 
org.apache.fineract.infrastructure.bulkimport.populator.savings.SavingsWorkbookPopulator.setNames(SavingsWorkbookPopulator.java:335)
 ~[main/:na]
        at 
org.apache.fineract.infrastructure.bulkimport.populator.savings.SavingsWorkbookPopulator.setRules(SavingsWorkbookPopulator.java:226)
 ~[main/:na]
        at 
org.apache.fineract.infrastructure.bulkimport.populator.savings.SavingsWorkbookPopulator.populate(SavingsWorkbookPopulator.java:70)
 ~[main/:na]
        at 
org.apache.fineract.infrastructure.bulkimport.service.BulkImportWorkbookPopulatorServiceImpl.getTemplate(BulkImportWorkbookPopulatorServiceImpl.java:220)
 ~[main/:na]
        at 
org.apache.fineract.portfolio.savings.api.SavingsAccountsApiResource.getSavingsTemplate(SavingsAccountsApiResource.java:526)
 ~[main/:na] {noformat}
What I don't understand is how the build is green on 
[https://travis-ci.org/github/apache/fineract/branches] with this. I don't see 
any PRs which were recently merged without green builds that could have broken 
this. Weird. Anyway.

> SavingsWorkbookPopulateTest testSavingsWorkbookPopulate() is flaky
> ------------------------------------------------------------------
>
>                 Key: FINERACT-1256
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1256
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Michael Vorburger
>            Priority: Major
>             Fix For: 1.5.0
>
>
> https://travis-ci.org/github/apache/fineract/builds/741992238 for 
> https://github.com/apache/fineract/pull/1494 failed with:
> SavingsWorkbookPopulateTest > testSavingsWorkbookPopulate() FAILED
>     java.lang.AssertionError: 1 expectation failed.
>     Expected status code <200> but was <500>.
> I suspect that is NOT due to a change in that PR, but that test is just 
> "flaky".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to