[ 
https://issues.apache.org/jira/browse/FINERACT-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227678#comment-17227678
 ] 

Michael Vorburger commented on FINERACT-1256:
---------------------------------------------

Oh, I've figured it out... :( silly me, this test failure WAS because of 
[https://github.com/apache/fineract/pull/1494] (only, and wouldn't happen on 
develop; I just locally saw it because my DB was "dirty"), because the 
new-style fineract-client SDK OfficeTest moved for FINERACT-1209 created a 
TestOffice-... and the {{SavingsWorkbookPopulator}} couldn't handle office 
names with hyphens. I'll add a commit to the PR to make it pass, but improve 
{{SavingsWorkbookPopulator}} anyway (and change the title of this issue.

> SavingsWorkbookPopulateTest testSavingsWorkbookPopulate() is flaky
> ------------------------------------------------------------------
>
>                 Key: FINERACT-1256
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1256
>             Project: Apache Fineract
>          Issue Type: Bug
>            Reporter: Michael Vorburger
>            Assignee: Michael Vorburger
>            Priority: Major
>             Fix For: 1.5.0
>
>
> https://travis-ci.org/github/apache/fineract/builds/741992238 for 
> https://github.com/apache/fineract/pull/1494 failed with:
> SavingsWorkbookPopulateTest > testSavingsWorkbookPopulate() FAILED
>     java.lang.AssertionError: 1 expectation failed.
>     Expected status code <200> but was <500>.
> I suspect that is NOT due to a change in that PR, but that test is just 
> "flaky".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to