[
https://issues.apache.org/jira/browse/FINERACT-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467692#comment-17467692
]
Aleksandar Vidakovic commented on FINERACT-1474:
------------------------------------------------
[~vorburger] I agree... after cross-reading that test it seems to me that we
have a dependency on an Azure deployment which is already in itself a bad
practice from my point of view (who deployed it? do we have access to it if
something breaks? is the remote Azure instance even a Fineract backend?) ... we
have no access to that machine and when it disappears for some reason then we
have a global blocker. The test implementation doesn't reveal too much what
it's actually about... it looks like a very specific report that is retrieved;
really don't see how this helps in a broader context.
Having said all that: I would vote to remove it or to rewrite the tests for
"localhost". If we vote to remove it then let me know, I can take care of it.
[~ptuomola], [~awasum] what do you think?
> Remove hard-coded constant from ThitsaworksCreditBureauTest
> -----------------------------------------------------------
>
> Key: FINERACT-1474
> URL: https://issues.apache.org/jira/browse/FINERACT-1474
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Priority: Blocker
>
> https://www.gitguardian.com is telling me that it thinks that the constant
> {{subscriptionKey}} (and probably others there such as {{subscriptionId}}) in
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/ThitsaworksCreditBureauTest.java
> is Not a Great Idea.
> I'm not sure what that's for, and won't have the time to look into it, but it
> does seem curious, so I thought I would at least file this issue.
> [[email protected]] ([~ptuomola]) and [~aleks] ([~avidakovic]
> [~vidakovic]) and [~awasum] FYI.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
