[
https://issues.apache.org/jira/browse/FINERACT-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17467726#comment-17467726
]
Aleksandar Vidakovic commented on FINERACT-1474:
------------------------------------------------
[~ptuomola] ... my mistake... I just saw the URL
"https://qa-mmcix-api.azurewebsites.net/20200324/api/Dashboard/GetCreditReport?uniqueId=2113439292";
and thought immediately some outside service is being called... but that thing
is contained in a JSON blob... so no problem, you are right.
Other suggestion: then let's replace subscriptionId and -key with something
like "XXX" and "YYY"; the values there look kind of real; maybe with the
replacement Git Guardian won't complain... and as this is all static content it
shouldn't make much of a difference.
Note: would really like to know what is actually tested here. Kind of feels
unnecessary, but I might just not understand enough.
> Remove hard-coded constant from ThitsaworksCreditBureauTest
> -----------------------------------------------------------
>
> Key: FINERACT-1474
> URL: https://issues.apache.org/jira/browse/FINERACT-1474
> Project: Apache Fineract
> Issue Type: Bug
> Reporter: Michael Vorburger
> Priority: Blocker
>
> https://www.gitguardian.com is telling me that it thinks that the constant
> {{subscriptionKey}} (and probably others there such as {{subscriptionId}}) in
> https://github.com/apache/fineract/blob/develop/fineract-provider/src/test/java/org/apache/fineract/portfolio/loanaccount/ThitsaworksCreditBureauTest.java
> is Not a Great Idea.
> I'm not sure what that's for, and won't have the time to look into it, but it
> does seem curious, so I thought I would at least file this issue.
> [[email protected]] ([~ptuomola]) and [~aleks] ([~avidakovic]
> [~vidakovic]) and [~awasum] FYI.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
