[
https://issues.apache.org/jira/browse/FINERACT-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18014021#comment-18014021
]
Adam Monsen commented on FINERACT-2341:
---------------------------------------
{quote}Correct would be 1.12.1.
{quote}
I disagree. For a non-release nightly/test/dev version built right from source,
the "version" is (as of today, off the {{develop}} branch) "something after
1.12.1". I'd rather see a version number like exactly what {{git describe}}
spits out, e.g. {{1.12.1-72-g1e1787399}} for the [tip of {{develop}} right
now|https://github.com/apache/fineract/commit/1e1787399a450969e7edc918a5008b48db51963d].
We also use the version number derived by the git versioning plugin in .jar
file names (the .jar files that are created as part of the build process) so
it's worth looking into if we're straying from some or other common [naming
convention|https://stackoverflow.com/questions/5901378/what-exactly-is-a-maven-snapshot-and-why-do-we-need-it].
Does it matter though? Do we (the Fineract project) release nightly/test/dev
build products anywhere?
For something built from {{1.12.1-72-g1e1787399}} I'd also support
{{1.12.2-SNAPSHOT}} (just "the next patch release") but I don't love it. And I
don't love {{1.13.0-SNAPSHOT}} either, honestly. The git describe output gives
way more info. But meh, I don't really care that much I guess.
The web app can also go ahead and show {{1.12.1-72-g1e1787399}} today with no
changes to Fineract since as we discussed in chat, it already has this from the
[actuator|https://sandbox.mifos.community/fineract-provider/actuator/info] at
{{git.commit.id.describe}} (but of course this doesn't help confusing version
numbers in built .jar files and such).
> Gradle versioning plugin configuration suggests wrong versions
> --------------------------------------------------------------
>
> Key: FINERACT-2341
> URL: https://issues.apache.org/jira/browse/FINERACT-2341
> Project: Apache Fineract
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.12.1
> Reporter: Felix Van Hove
> Priority: Trivial
>
> If I clone, check out a specific release of Fineract and then do `gradlew
> bootRun`, the running instance does not show the correct version. (This is
> not a new problem with 1.12.x, but had been the case with 1.11.0 too.)
> E.g. for 1.12.1, the Swagger UI displays 1.13.1-SNAPSHOT as the version. The
> same version appears here:
> {noformat}
> $ find . -name "fineract-*.jar" -path "*/build/*"
> ./fineract-accounting/build/libs/fineract-accounting-1.13.1-SNAPSHOT.jar
> ./fineract-avro-schemas/build/libs/fineract-avro-schemas-1.13.1-SNAPSHOT.jar
> ./fineract-branch/build/libs/fineract-branch-1.13.1-SNAPSHOT.jar
> ./fineract-charge/build/libs/fineract-charge-1.13.1-SNAPSHOT.jar
> ./fineract-command/build/libs/fineract-command-1.13.1-SNAPSHOT.jar
> ./fineract-core/build/libs/fineract-core-1.13.1-SNAPSHOT.jar
> ./fineract-document/build/libs/fineract-document-1.13.1-SNAPSHOT.jar
> ./fineract-investor/build/libs/fineract-investor-1.13.1-SNAPSHOT.jar
> ./fineract-loan/build/libs/fineract-loan-1.13.1-SNAPSHOT.jar
> ./fineract-progressive-loan/build/libs/fineract-progressive-loan-1.13.1-SNAPSHOT.jar
> ./fineract-rates/build/libs/fineract-rates-1.13.1-SNAPSHOT.jar
> ./fineract-report/build/libs/fineract-report-1.13.1-SNAPSHOT.jar
> ./fineract-savings/build/libs/fineract-savings-1.13.1-SNAPSHOT.jar
> ./fineract-tax/build/libs/fineract-tax-1.13.1-SNAPSHOT.jar
> ./fineract-validation/build/libs/fineract-validation-1.13.1-SNAPSHOT.jar
> {noformat}
> Correct would be 1.12.1.
> If I download a development version after the release 1.12.1, the same
> 1.13.1-SNAPSHOT version is generated. Correct would be 1.13.0-SNAPSHOT.
> The reason is a misconfiguration of the [Gradle versioning
> plugin|https://github.com/qoomon/gradle-git-versioning-plugin] via the file
> build.gradle.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
