[
https://issues.apache.org/jira/browse/FINERACT-2341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18017872#comment-18017872
]
Felix Van Hove commented on FINERACT-2341:
------------------------------------------
I set up the following list of use cases for my testing:
develop branch ("Retain major version, advance minor version, reset patch
version to 0 and add SNAPSHOT suffix!")
Branch is develop, last tag is 1.12.0, version should be 1.13.0-SNAPSHOT
Branch is develop, last tag is 1.12.1, version should be 1.13.0-SNAPSHOT
tag, headless ("Retain version!")
Tag is checked out, tag is 1.12.0, version should be 12.0.1
Tag is checked out, tag is 1.12.1, version should be 1.12.1
tag is last version in branch ("Retain version!")
Tag is checked out, tag is 1.12.0, version should be 12.0.1
Tag is checked out, tag is 1.12.1, version should be 1.12.1
release branch ("Keep current behaviour: retain version!")
Branch is release/1.12.0, last tag is 1.11.0, version should be 1.12.0
Branch is release/1.12.1, last tag is 1.12.0, version should be 1.12.1
maintenance branch ("Keep current behaviour: retain version!")
Branch is maintenance/1.12.0, last tag is 1.11.0, version should be 1.12.0
Branch is maintenance/1.12.1, last tag is 1.12.0, version should be 1.12.1
other branch ("Do the same as what you do on the develop branch!")
Branch is foo, last tag is 1.12.0, version should be 1.13.0-SNAPSHOT
Branch is foo, last tag is 1.12.1, version should be 1.13.0-SNAPSHOT
> Gradle versioning plugin configuration suggests wrong versions
> --------------------------------------------------------------
>
> Key: FINERACT-2341
> URL: https://issues.apache.org/jira/browse/FINERACT-2341
> Project: Apache Fineract
> Issue Type: Bug
> Components: Build
> Affects Versions: 1.12.1
> Reporter: Felix Van Hove
> Priority: Trivial
>
> If I clone, check out a specific release of Fineract and then do `gradlew
> bootRun`, the running instance does not show the correct version. (This is
> not a new problem with 1.12.x, but had been the case with 1.11.0 too.)
> E.g. for 1.12.1, the Swagger UI displays 1.13.1-SNAPSHOT as the version. The
> same version appears here:
> {noformat}
> $ find . -name "fineract-*.jar" -path "*/build/*"
> ./fineract-accounting/build/libs/fineract-accounting-1.13.1-SNAPSHOT.jar
> ./fineract-avro-schemas/build/libs/fineract-avro-schemas-1.13.1-SNAPSHOT.jar
> ./fineract-branch/build/libs/fineract-branch-1.13.1-SNAPSHOT.jar
> ./fineract-charge/build/libs/fineract-charge-1.13.1-SNAPSHOT.jar
> ./fineract-command/build/libs/fineract-command-1.13.1-SNAPSHOT.jar
> ./fineract-core/build/libs/fineract-core-1.13.1-SNAPSHOT.jar
> ./fineract-document/build/libs/fineract-document-1.13.1-SNAPSHOT.jar
> ./fineract-investor/build/libs/fineract-investor-1.13.1-SNAPSHOT.jar
> ./fineract-loan/build/libs/fineract-loan-1.13.1-SNAPSHOT.jar
> ./fineract-progressive-loan/build/libs/fineract-progressive-loan-1.13.1-SNAPSHOT.jar
> ./fineract-rates/build/libs/fineract-rates-1.13.1-SNAPSHOT.jar
> ./fineract-report/build/libs/fineract-report-1.13.1-SNAPSHOT.jar
> ./fineract-savings/build/libs/fineract-savings-1.13.1-SNAPSHOT.jar
> ./fineract-tax/build/libs/fineract-tax-1.13.1-SNAPSHOT.jar
> ./fineract-validation/build/libs/fineract-validation-1.13.1-SNAPSHOT.jar
> {noformat}
> Correct would be 1.12.1.
> If I download a development version after the release 1.12.1, the same
> 1.13.1-SNAPSHOT version is generated. Correct would be 1.13.0-SNAPSHOT.
> The reason is a misconfiguration of the [Gradle versioning
> plugin|https://github.com/qoomon/gradle-git-versioning-plugin] via the file
> build.gradle.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
