[ 
https://issues.apache.org/jira/browse/FINERACT-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056859#comment-18056859
 ] 

Ashhar Ahmad Khan commented on FINERACT-2462:
---------------------------------------------

Hi @edk12564 , apologies for the duplicate PR. I see you’ve been working on 
this for a few days, and your PR *#5437* looks solid.

I noticed our approaches differ slightly (yours is more concise; mine adds more 
detailed error messaging). I’m happy to either *close mine* or *collaborate* 
and combine the best parts, whatever you prefer.

> Add a github action which checks if PR follows one person per commit 
> guidelines
> -------------------------------------------------------------------------------
>
>                 Key: FINERACT-2462
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2462
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: AMAN MITTAL
>            Assignee: Edward Kang
>            Priority: Minor
>              Labels: beginner-friendly
>
> According to contributing guidelines, FINERACT follows one person per commit, 
> so i think we can add a github action that automatically informs the PR that 
> it has multiple commits per user
> [https://github.com/apache/fineract/pull/5437]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to