[
https://issues.apache.org/jira/browse/FINERACT-2462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056861#comment-18056861
]
Edward Kang commented on FINERACT-2462:
---------------------------------------
Hi [~ashhar]. That sounds good to me. I was working on some edge cases (namely
when a contributor commits and fails to squash their old commits with a
different git email). Unfortunately, since the tests take so long to run, there
was a delay. I also adjusted tests to run on the main repo's context. I will
push my changes now.
Could you pull my changes and work on the addition to add a comment that
informs each user to squash their changes on old PRs as well (that are not
stale)? This would be a cron based implementation. See Aman's comment in the PR
please.
> Add a github action which checks if PR follows one person per commit
> guidelines
> -------------------------------------------------------------------------------
>
> Key: FINERACT-2462
> URL: https://issues.apache.org/jira/browse/FINERACT-2462
> Project: Apache Fineract
> Issue Type: Improvement
> Reporter: AMAN MITTAL
> Assignee: Edward Kang
> Priority: Minor
> Labels: beginner-friendly
>
> According to contributing guidelines, FINERACT follows one person per commit,
> so i think we can add a github action that automatically informs the PR that
> it has multiple commits per user
> [https://github.com/apache/fineract/pull/5437]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
