[ 
https://issues.apache.org/jira/browse/FINERACT-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18061136#comment-18061136
 ] 

Adam Monsen edited comment on FINERACT-2484 at 2/25/26 6:08 PM:
----------------------------------------------------------------

If/when you add commits to this PR (and others) in this repo, please leave the 
commits as-is/un-squashed. Try to avoid force-pushing (just save that for 
mistakes/noise not helpful for posterity and let collaborators know when you 
force push – use your best judgment on when to squash/rebase/force-push). I 
like to see progress along the way, changes reversed, etc. Ideally with commit 
log detail about the "why"/intent for the changes, summaries of our discussions 
leading to the changes, ideas/plans for future changes, etc.

Note this methodology for source control (keeping a series of PR commits 
un-squashed) is a different policy than we use for the {{apache/fineract}} repo.


was (Author: meonkeys):
I'll make some suggestions. If/when you add commits, please leave them 
as-is/un-squashed. Try to avoid force-pushing (just save that for 
mistakes/noise not helpful for posterity and let collaborators know when you do 
– use your best judgment on when to squash/rebase/force-push). I like to see 
progress along the way, changes reversed, etc. Ideally with commit log detail 
about the "why"/intent for the changes, summaries of our discussions leading to 
the changes, ideas/plans for future changes, etc.

Note this methodology for source control (keeping a series of PR commits 
un-squashed) is a different policy than we use for the {{apache/fineract}} repo.

> further improve fineract.apache.org website
> -------------------------------------------
>
>                 Key: FINERACT-2484
>                 URL: https://issues.apache.org/jira/browse/FINERACT-2484
>             Project: Apache Fineract
>          Issue Type: Improvement
>          Components: Docs
>    Affects Versions: 1.14.0
>            Reporter: Adam Monsen
>            Priority: Major
>             Fix For: 1.15.0
>
>         Attachments: FINERACT_SITE_MIGRATION_PLAN.md, Wave-analysis.png, 
> checker.png, fineract resolved.png, overlap.webp
>
>
> Continue work started in FINERACT-2192.
> ✅ [fineract.apache.org|https://fineract.apache.org] [project 
> website|https://infra.apache.org/project-site.html] must [pass all ASF whimsy 
> tool checks|https://whimsy.apache.org/site/project/fineract]
> ▶️ use a static site generator, don't hand-code HTML (if we use a tool like 
> jekyll, hugo, or pelican, do the building in a container)
> ▶️ use the same static site generation mechanism for {{security.html}} 
> (currently done semi-automated locally by hand, see {{{}src/security/{}}})
> ✅ fix text overlap (see attached {{overlap.webp}} screenshot)
> ✅ similar to the chat archiver, auto-switch between dark and light mode based 
> on user's current desktop preference using a [{{prefers-color-scheme}} media 
> query|https://caniuse.com/wf-prefers-color-scheme]
> ✅ document how to test locally, before/while committing



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to