meonkeys commented on PR #17:
URL: 
https://github.com/apache/fineract-chat-archive/pull/17#issuecomment-4025655186

   This looks good but I'm sorry, something is still not quite right! 
Idempotency test (re-running the archiver locally) is failing.
   
   I ran the archiver from 187fe96992d29da5dd5d392370e6bda09007b7ac locally 
against my clone of `https://github.com/mifos/chat-archive/` at 
c04b13dde2cdb6a34d415c85cf0fc372031875fb. I set `LOOKBACK_DAYS=4`. [Here is the 
result](https://github.com/meonkeys/mifos-chat-archive/commit/83ce6e7ffa8f7733f841d26284bf925d7143ed9f).
   
   It looks like some messages were missing (never archived) from March 6.
   
   Can you repro this? Any ideas as to root cause? Something more to do with 
timezones, or perhaps `LOOKBACK_DAYS`, or something else?
   
   Note I'm ignoring that [the archiver wasn't run by github 
today](https://github.com/mifos/chat-archive/actions?query=event%3Aschedule++)...
 I'm guessing that will self-resolve. But maybe [`LOOKBACK_DAYS` in the 
scheduled 
run](https://github.com/mifos/chat-archive/blob/main/.github/workflows/update-archive.yml)
 should be 2, or even 3? What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to