nidhiii128 commented on PR #17: URL: https://github.com/apache/fineract-chat-archive/pull/17#issuecomment-4029182004
hii @meonkeys, I want to apologize for taking extra time and for the previous iterations that didn't quite meet the requirements. I wanted to be absolutely sure I had baselined my local environment correctly and verified the idempotency before resubmitting. I made a few changes , i replaced Instant.now() window start with a 'snapped' hourly timestamp. This ensures the 4-day window remains identical for any run within the same 60-minute block. Also for the verification i used my slack token, the message i posted on 5th march using my own Slack token, I confirmed the tool correctly fetches/excludes messages based on the window. I verified that a message from March 5th was correctly included when LOOKBACK_DAYS was set to 6 and excluded when set to 4, but since the actual slack token counts messages in seconds i couldnt verify that. Verification on my changes when i ran git status no unnecessary changes were made to the archived HTML files. which prevent the 24-hour 'jump' that occurs when a script runs across a UTC day-boundary, ensuring no messages (like those from March 6th) are dropped due to time drift. please review by ur side and let me know if i need to know more on this. Thank you for your patience and for the guidance on this fix! and on your message "" I'm guessing that will self-resolve. But maybe LOOKBACK_DAYS in the scheduled run should be 2, or even 3? What do you think? "" i am not sure abt this i made those changes, and if those changes are also creating the same problem then i think this would be the next reason of failing or unnecessary deleting of message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
